mapleFU commented on code in PR #1419:
URL:
https://github.com/apache/incubator-kvrocks/pull/1419#discussion_r1185665485
##########
x.py:
##########
@@ -216,16 +216,18 @@ def write_version(release_version: str) -> str:
return version
-def package_source(release_version: str) -> None:
+def package_source(release_version: str, release_candidate_number:
Optional[int]) -> None:
# 0. Write input version to VERSION file
version = write_version(release_version)
# 1. Git commit and tag
git = find_command('git', msg='git is required for source packaging')
run(git, 'commit', '-a', '-m', f'[source-release] prepare release
apache-kvrocks-{version}')
- run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for tag
v{version}')
-
-
+ if release_candidate_number == None:
+ run(git, 'tag', '-a', f'v{version}', '-m', f'[source-release] copy for
tag v{version}')
+ else:
+ run(git, 'tag', '-a', f'v{version}-rc{release_candidate_number}',
'-m', f'[source-release] copy for tag v{version}')
Review Comment:
```
f'[source-release] copy for tag v{version}-rc{release_candidate_number}'
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
