infdahai commented on code in PR #1464:
URL:
https://github.com/apache/incubator-kvrocks/pull/1464#discussion_r1201537078
##########
tests/gocase/integration/slotmigrate/slotmigrate_test.go:
##########
@@ -412,23 +412,19 @@ func TestSlotMigrateSync(t *testing.T) {
})
t.Run("MIGRATE - Migrate sync with (or without) all kinds of timeouts",
func(t *testing.T) {
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync").Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", -1).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 0).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 10).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 0.5).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", -3.14).Val())
+ slot := 1024
Review Comment:
So when I use a very small time parameter causing a failure, the program
calls `resume` func and returns `nil` value. Maybe we need the following test.
But the following statements may fail from my tests.
```go
// for result.Val() == nil && timeout < 15 {
// timeout += 5
// result := rdb0.Do(ctx, "clusterx",
"migrate", slot, id1, "sync", timeout)
// require.NoError(t, result.Err())
// }
// require.Equal(t, "OK", result.Val())
```
##########
tests/gocase/integration/slotmigrate/slotmigrate_test.go:
##########
@@ -412,23 +412,19 @@ func TestSlotMigrateSync(t *testing.T) {
})
t.Run("MIGRATE - Migrate sync with (or without) all kinds of timeouts",
func(t *testing.T) {
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync").Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", -1).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 0).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 10).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", 0.5).Val())
-
- slot++
- require.Equal(t, "OK", rdb0.Do(ctx, "clusterx", "migrate",
slot, id1, "sync", -3.14).Val())
+ slot := 1024
Review Comment:
So when I use a very small time parameter causing a failure, the program
calls `resume` func and returns `nil` value. Maybe we need the following test.
But the following statements may fail from my tests.
```go
// for result.Val() == nil && timeout < 15 {
// timeout += 5
// result := rdb0.Do(ctx, "clusterx",
"migrate", slot, id1, "sync", timeout)
// require.NoError(t, result.Err())
// }
// require.Equal(t, "OK", result.Val())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
