git-hulk commented on code in PR #1464:
URL:
https://github.com/apache/incubator-kvrocks/pull/1464#discussion_r1202540403
##########
src/cluster/sync_migrate_context.h:
##########
@@ -25,7 +25,7 @@
class SyncMigrateContext : private EvbufCallbackBase<SyncMigrateContext,
false>,
private EventCallbackBase<SyncMigrateContext> {
public:
- SyncMigrateContext(Server *svr, redis::Connection *conn, float timeout) :
svr_(svr), conn_(conn), timeout_(timeout){};
+ SyncMigrateContext(Server *svr, redis::Connection *conn, int timeout) :
svr_(svr), conn_(conn), timeout_(timeout){};
Review Comment:
We should do it in util::ParseXXX test cases instead of here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
