PragmaTwice commented on code in PR #1468:
URL: 
https://github.com/apache/incubator-kvrocks/pull/1468#discussion_r1204133957


##########
src/commands/cmd_zset.cc:
##########
@@ -745,6 +822,7 @@ REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandZAdd>("zadd", 
-4, "write", 1, 1, 1),
                         MakeCmdAttr<CommandZLexCount>("zlexcount", 4, 
"read-only", 1, 1, 1),
                         MakeCmdAttr<CommandZPopMax>("zpopmax", -2, "write", 1, 
1, 1),
                         MakeCmdAttr<CommandZPopMin>("zpopmin", -2, "write", 1, 
1, 1),
+                        MakeCmdAttr<CommandZMPop>("zmpop", -4, "write", 1, 1, 
1),

Review Comment:
   ```suggestion
                           MakeCmdAttr<CommandZMPop>("zmpop", -4, "write", 2, 
2, 1),
   ```
   
   You can refer to 
https://github.com/apache/incubator-kvrocks/pull/1444#discussion_r1201874256 
for a more concrete solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to