xxaier commented on PR #1474: URL: https://github.com/apache/incubator-kvrocks/pull/1474#issuecomment-1562400477
> I acknowledge your idea to pass env vars as options, but IMHO the shell script composed by `sed` and some other text substitution tools looks terrible to me since it is more like workaround than a real solution. > > BTW, shell scripts are hard to maintain and be general-purpose enough. Our development scripts are all written in python, refer to `x.py`. > > For [docker/build.sh](https://github.com/apache/incubator-kvrocks/pull/1474/files#diff-efe74abc7213e95246105b4a7b029557ef16ff997e9cc13eadcfffa18e6757c0), I think we do not need the script. You can learn how our community build and release docker images from https://kvrocks.apache.org/community/create-a-release . > > And for [docker/docker-compose.yml](https://github.com/apache/incubator-kvrocks/pull/1474/files#diff-423deb13b7c401b1a7f41ee91c77f722e11d2f317d6a66b546524e8a04cc8b03), I think we do not need an example compose file, and I really do not know why these arguments are chosen and are suitable for various kvrocks users, e.g. `mem_limit: 2G` `memswap_limit: -1`. The reason why I don't use python is that in order to keep the size of the final docker container from growing, the final docker image will not contain the python runtime. The reason I added build.sh is that when developing and debugging docker, there will be a need for local construction, such as building a database based on kvrocks+topling https://github.com/apache/incubator-kvrocks/pull/1206. I think local development and building docker debugging is also a common scenario, and it is very troublesome to manually enter commands every time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
