tisonkun commented on code in PR #1477:
URL: 
https://github.com/apache/incubator-kvrocks/pull/1477#discussion_r1207936279


##########
Dockerfile:
##########
@@ -31,36 +27,23 @@ RUN ./x.py build -DENABLE_OPENSSL=ON -DPORTABLE=ON 
-DCMAKE_BUILD_TYPE=Release -j
 
 FROM alpine:3.16
 
-ENV TZ=Etc/UTC
-RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
-
 RUN apk upgrade && apk add libexecinfo
-
-WORKDIR /kvrocks
-
 RUN mkdir /var/run/kvrocks && mkdir /var/lib/kvrocks
-
 RUN addgroup -S kvrocks && adduser -D -H -S -G kvrocks kvrocks
-
 RUN chown kvrocks:kvrocks /var/run/kvrocks && chown kvrocks:kvrocks 
/var/lib/kvrocks
 
 USER kvrocks
-
-COPY --from=build /kvrocks/build/kvrocks ./bin/
-COPY --from=build /usr/bin/redis-cli ./bin/
-
-HEALTHCHECK --interval=10s --timeout=1s --start-period=30s --retries=3 CMD 
./bin/redis-cli -p 6666 PING | grep -E '(PONG|NOAUTH)' || exit 1
-
-ENV PATH="$PATH:/kvrocks/bin"
-
 VOLUME /var/lib/kvrocks
 
-RUN chown kvrocks:kvrocks /var/lib/kvrocks

Review Comment:
   Duplicated above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to