jihuayu opened a new pull request, #1479: URL: https://github.com/apache/incubator-kvrocks/pull/1479
I have followed the rules below and completed all the modifications. https://github.com/apache/incubator-kvrocks/issues/1451#issuecomment-1565481854 > ### The files match `types/redis_*.h` > > - For the function similar to [`Set#IsMember`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/types/redis_set.h#L36) or [`String#SetNX`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/types/redis_string.h#L47) that `ret` means the flag, I will change it to `bool *flag` > > - For the function similar to [`Set#Remove`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/types/redis_set.h#L39) that `ret` means the number of removed elements, I will change it to `uint64_t *removed_cnt` > > - For the function similar to [`List#Size`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/types/redis_list.h#L36) that `ret` means the size of list, I will change it to `uint64_t *size` > > - For the function similar to [`List#Size`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/types/redis_list.h#L36) that `ret` means the size of list, I will change it to `uint64_t *size` > > - For the function similar to [`String#IncrBy`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/types/redis_string.h#L50) that `ret` means the new value, I will change it to `int64_t *new_value` > > - In cases where `ret` may be negative, I will set the type to `int*`. > > ### The files match `commands/cmd_*.cc` > > I will change the type of `int ret` to the correct type, but I will **not change the variable name** because it represents the return value of the Redis command. > > ### The test files > > I will change the type of `int ret` to the correct type, and I will decide whether to modify the variable name based on the situation. > > > ### All files > > I will remove all unnecessary `static_cast` statements. > > **I will use `uint64_t`([`Metadata#size`](https://github.com/apache/incubator-kvrocks/blob/unstable/src/storage/redis_metadata.h#L121) type) as the type for length everywhere, instead of the `size_t`.** > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
