git-hulk commented on PR #1479:
URL:
https://github.com/apache/incubator-kvrocks/pull/1479#issuecomment-1568585951
> @git-hulk I don't think using `redis::Bool` is appropriate. The meaning of
`redis::Integer` function is to return a Integer RESP, not process a Integer.
Even though we are passing in a `bool` here, we need to return a Integer RESP,
so I think `redis::Integer` function is more appropriate.
We already have `redis::Integer` function now, what I mean is to add
redis::Bool based on the Integer function like below:
```
std::string Bool(b bool) {
return redis::Integer(ret ? 1 : 0)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
