jihuayu commented on issue #755: URL: https://github.com/apache/incubator-kvrocks/issues/755#issuecomment-1575372305
Now kvrocks don't save stat data for each namespace, if we need make it we should save stat for each namespace. we can change `Server#stats` to a map that save namespace to stat mapping. This will increase additional cost above: 1. Roughly 2KB memory usage per namespace 2. lock namespace-stat map when we add namespace 3. One more indirect addressing for access stat 4. Administrator `info` command need to foreach all namespace stat and count sum/average. For 1rd we won't have thousands of namespace, so this memory usage is not large. For 2nd add namespace is low-frequency operation and it is fast. For 3rd if we think indirect addressing expensive, we can cache it in connect.(I don't think this is necessary) For 4rd this is not important. I think them is acceptable. So do we need do it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
