uds5501 commented on code in PR #1502:
URL:
https://github.com/apache/incubator-kvrocks/pull/1502#discussion_r1234291141
##########
src/types/redis_zset.cc:
##########
@@ -744,16 +754,15 @@ rocksdb::Status ZSet::UnionStore(const Slice &dst, const
std::vector<KeyWeight>
}
}
}
- if (!dst_zset.empty()) {
- std::vector<MemberScore> mscores;
- mscores.reserve(dst_zset.size());
+ auto compare_score = [](const MemberScore &score1, const MemberScore
&score2) { return score1.score < score2.score; };
Review Comment:
@torwig / @git-hulk needed an opinion on this. If the scores of both the
members are same during sorting, do we want to also lexicographically check the
members as tie breakers or are we okay with them being in the order which they
were originally present in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
