jihuayu commented on PR #1489: URL: https://github.com/apache/incubator-kvrocks/pull/1489#issuecomment-1598263094
> And notice that cursor_dict_'s cursor and other element is not atomic, if there are huge number of scan, it might produce bad result or concurrent read/write key_name. But maybe it's ok not to handle this? This will not cause errors. Firstly, the assignment operation is atomic, so there will be no problem with the correspondence between the cursor and the key name. Secondly, the network transmission speed is much slower than the synchronization of cache data, so there will be no inconsistency in the cache. > Can cursor be encapsulated to avoid explicit bit-ops outside? Our cursor is becoming increasingly complex, and it can indeed be encapsulated separately. > Do we need test bugfix? If anyone feels that additional testing is needed, they can raise it. I will go to add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
