git-hulk commented on code in PR #1502:
URL:
https://github.com/apache/incubator-kvrocks/pull/1502#discussion_r1236170266
##########
tests/cppunit/command_parser_test.cc:
##########
@@ -26,9 +26,10 @@ TEST(CommandParser, Parse) {
// [ HELLO i1 v1 | HI v2 ] [X i2 | Y]
std::vector<std::string> c1{"hello", "1", "a"}, c2{"hi", "b"}, c3{"hi", "c",
"x", "2"}, c4{"hello", "3", "d", "y"},
c5{"hi", "e", "y"}, c6{"y"}, d1{"hello"}, d2{"hi"}, d3{"hello",
"no-int"}, d4{"x", "1", "y"},
- d5{"hello", "1", "v", "hi", "v"}, d6{"hello", "1"};
+ d5{"hello", "1", "v", "hi", "v"}, d6{"hello", "1"}, d7{"float_test",
"1.1", "c"};
Review Comment:
```suggestion
d5{"hello", "1", "v", "hi", "v"}, d6{"hello", "1"}, d7{"float_test",
"1.1"};
```
Adding extra "c" will cause invalid syntax in the parser since it cannot be
recognized.
##########
tests/cppunit/command_parser_test.cc:
##########
@@ -26,9 +26,10 @@ TEST(CommandParser, Parse) {
// [ HELLO i1 v1 | HI v2 ] [X i2 | Y]
std::vector<std::string> c1{"hello", "1", "a"}, c2{"hi", "b"}, c3{"hi", "c",
"x", "2"}, c4{"hello", "3", "d", "y"},
c5{"hi", "e", "y"}, c6{"y"}, d1{"hello"}, d2{"hi"}, d3{"hello",
"no-int"}, d4{"x", "1", "y"},
- d5{"hello", "1", "v", "hi", "v"}, d6{"hello", "1"};
+ d5{"hello", "1", "v", "hi", "v"}, d6{"hello", "1"}, d7{"float_test",
"1.1", "c"};
Review Comment:
```suggestion
d5{"hello", "1", "v", "hi", "v"}, d6{"hello", "1"}, d7{"float_test",
"1.1"};
```
Adding an extra "c" will cause invalid syntax in the parser since it cannot
be recognized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
