uds5501 commented on code in PR #1502:
URL:
https://github.com/apache/incubator-kvrocks/pull/1502#discussion_r1236223511
##########
src/types/redis_zset.cc:
##########
@@ -744,16 +754,20 @@ rocksdb::Status ZSet::UnionStore(const Slice &dst, const
std::vector<KeyWeight>
}
}
}
- if (!dst_zset.empty()) {
- std::vector<MemberScore> mscores;
- mscores.reserve(dst_zset.size());
+ auto compare_score = [](const MemberScore &score1, const MemberScore
&score2) {
+ if (score1.score == score2.score) {
+ return score1.member < score2.member;
+ }
+ return score1.score < score2.score;
+ };
+ if (members && !dst_zset.empty()) {
+ members->reserve(dst_zset.size());
for (const auto &iter : dst_zset) {
- mscores.emplace_back(MemberScore{iter.first, iter.second});
+ members->emplace_back(MemberScore{iter.first, iter.second});
}
- if (saved_cnt) *saved_cnt = mscores.size();
- Overwrite(dst, mscores);
+ if (saved_cnt) *saved_cnt = members->size();
+ std::sort(members->begin(), members->end(), compare_score);
Review Comment:
Underlying storage will sort them for ZUNIONSTORE, but we don’t use the
storage for ZUNION, so i think to keep the response consistent, we’ll need to
sort it at this level (atleast for ZUNION) command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
