tisonkun commented on code in PR #113:
URL: https://github.com/apache/kvrocks-website/pull/113#discussion_r1238571028
##########
src/components/Releases/index.tsx:
##########
@@ -14,9 +14,13 @@ type ReleaseData = {
signature: string,
}
-function createReleaseData(version: string): ReleaseData {
- const vtag = `${version}-incubating`
- const archive =
`https://downloads.apache.org/incubator/kvrocks/${version}/apache-kvrocks-${vtag}-src.tar.gz`
+function createReleaseData(index: number, version: string): ReleaseData {
+ var vtag = `${version}-incubating`
+ // Drop the incubating suffix for releases after graduation
+ if (index >= 4) {
+ vtag = `${version}`
+ }
Review Comment:
Why not inline the version to the `versions` list so that we don't do
if-else here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
