tisonkun commented on code in PR #114:
URL: https://github.com/apache/kvrocks-website/pull/114#discussion_r1238592286
##########
src/components/Releases/index.tsx:
##########
@@ -14,23 +26,19 @@ type ReleaseData = {
signature: string,
}
-function createReleaseData(index: number, version: string): ReleaseData {
- var vtag = `${version}-incubating`
- // Drop the incubating suffix for releases after graduation
- if (index >= 4) {
- vtag = `${version}`
- }
- const archive =
`https://downloads.apache.org/kvrocks/${version}/apache-kvrocks-${vtag}-src.tar.gz`
+function createReleaseData(version: string, vtag?: string): ReleaseData {
+ const fixedVTag = vtag ?? version;
Review Comment:
I noticed that the downloads link are use `2.4.0` so we do have two concepts
here. But later we can populate only the `version` field and if we add a
`semver` dependency, we can do a test against version string (anyway, not
depend on array index).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
