git-hulk commented on code in PR #1710:
URL: https://github.com/apache/kvrocks/pull/1710#discussion_r1309697796
##########
src/types/redis_bloom_chain.cc:
##########
@@ -151,6 +151,7 @@ rocksdb::Status BloomChain::Add(const Slice &user_key,
const Slice &item, int *r
s = bloomCheck(bf_key_list[check_index], item_string, ret);
Review Comment:
I think we should add another variable to identify the check result(e.g.
exists or check_ret) instead of resuing the add result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
