mapleFU commented on PR #1704: URL: https://github.com/apache/kvrocks/pull/1704#issuecomment-1699537570
(Maybe not write `group_number` if it's 0 is not a good idea. Because if we support more config later, we will lack a flag shows that what's the logic content after 88 bytes. It's ok to not testing it. If we want test it, just `Encode` and build a subslice for it. ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
