xq2010 commented on PR #1798: URL: https://github.com/apache/kvrocks/pull/1798#issuecomment-1753221701
> Thank you! Sounds good to me, but [namespace] seems unnecessary since it knows the current namespace once it enters the command.↳ Yes, it's unnecessary to use a namespace. If the RDB file contains multiple db, the current implementation sets the namespace of each db to \<ns\>_\<db number\>. The password will be the same as the namespace. Only db 0 will use the current namespace. Perhaps using a parameter to specify which db to load would be better. If so, the command would be rdb load \<path\> [database number (default 0)]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
