mapleFU commented on code in PR #1829:
URL: https://github.com/apache/kvrocks/pull/1829#discussion_r1360121269


##########
src/commands/cmd_json.cc:
##########
@@ -52,7 +55,7 @@ class CommandJsonGet : public Commander {
   }
 };
 
-REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandJsonSet>("json.set", -3, "write", 
1, 1, 1),
+REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandJsonSet>("json.set", 3, "write", 1, 
1, 1),

Review Comment:
   We should use `-3` after set with `NX` support.
   
   Now I think we only support 3 arguments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to