torwig commented on code in PR #1833:
URL: https://github.com/apache/kvrocks/pull/1833#discussion_r1364924191
##########
src/commands/cmd_stream.cc:
##########
@@ -258,6 +258,30 @@ class CommandXGroup : public Commander {
return Status::OK();
}
+ if (subcommand_ == "setid") {
+ if (args.size() != 5 && args.size() != 7) {
+ return {Status::RedisParseErr, errWrongNumOfArguments};
+ }
+
+ xgroup_create_options_.last_id = GET_OR_RET(parser.TakeStr());
Review Comment:
Should we check here if the received ID is in a proper format? I mean
int_value-int_value/int_value/etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
