mapleFU commented on code in PR #1839:
URL: https://github.com/apache/kvrocks/pull/1839#discussion_r1366422835
##########
src/common/rdb_stream.cc:
##########
@@ -23,13 +23,13 @@
#include "fmt/format.h"
#include "vendor/crc64.h"
-StatusOr<size_t> RdbStringStream::Read(char *buf, size_t n) {
+Status RdbStringStream::Read(char *buf, size_t n) {
Review Comment:
I think if we require a fs api, we can wrap a
```
StatusOr<size_t> Read(buf, size_t);
StatusOr<Buffer> Read(..);
StatusOr<Buffer> ReadAt(..);
```
Style api as underlying impl, but this case I think rdb will gurantee the
size should match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
