guojidan commented on code in PR #1841:
URL: https://github.com/apache/kvrocks/pull/1841#discussion_r1367033302
##########
src/types/redis_json.cc:
##########
@@ -117,4 +117,39 @@ rocksdb::Status Json::Get(const std::string &user_key,
const std::vector<std::st
return rocksdb::Status::OK();
}
+rocksdb::Status Json::StrAppend(const std::string &user_key, const
std::vector<std::string> &paths, const std::string &value,
std::vector<uint64_t> &append_cnt) {
Review Comment:
Get && Set function`s path is std::string，Can you explain your doubt?
##########
src/types/redis_json.cc:
##########
@@ -117,4 +117,39 @@ rocksdb::Status Json::Get(const std::string &user_key,
const std::vector<std::st
return rocksdb::Status::OK();
}
+rocksdb::Status Json::StrAppend(const std::string &user_key, const
std::vector<std::string> &paths, const std::string &value,
std::vector<uint64_t> &append_cnt) {
Review Comment:
Get && Set function`s path is std::string，Can you explain your doubt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
