PragmaTwice commented on code in PR #1841:
URL: https://github.com/apache/kvrocks/pull/1841#discussion_r1370300524
##########
src/server/redis_reply.cc:
##########
@@ -34,6 +34,18 @@ std::string BulkString(const std::string &data) { return "$"
+ std::to_string(da
std::string NilString() { return "$-1" CRLF; }
+std::string IntegerArray(const std::vector<int64_t> &values, bool
output_nil_for_negative) {
Review Comment:
You do not to use `npos`. It is just a reference of the concept.
##########
src/server/redis_reply.cc:
##########
@@ -34,6 +34,18 @@ std::string BulkString(const std::string &data) { return "$"
+ std::to_string(da
std::string NilString() { return "$-1" CRLF; }
+std::string IntegerArray(const std::vector<int64_t> &values, bool
output_nil_for_negative) {
Review Comment:
You do not need to use `npos`. It is just a reference of the concept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
