mapleFU commented on code in PR #1856:
URL: https://github.com/apache/kvrocks/pull/1856#discussion_r1372527398
##########
tests/cppunit/types/json_test.cc:
##########
@@ -225,3 +225,44 @@ TEST_F(RedisJsonTest, Clear) {
ASSERT_TRUE(json_->Clear(key_, "$.some", &result).ok());
ASSERT_EQ(result, 0);
}
+
+TEST_F(RedisJsonTest, ArrLen) {
+ ASSERT_TRUE(
+ json_->Set(key_, "$",
R"({"a1":[1,2],"a2":[[1,5,7],[8],[9]],"i":1,"s":"string","o":{"a3":[1,1,1]}})").ok());
+ // 1. simple array
+ std::vector<std::optional<uint64_t>> res;
+ ASSERT_TRUE(json_->ArrLen(key_, "$.a1", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 2);
+ res.clear();
+ // 2. nested array
+ ASSERT_TRUE(json_->ArrLen(key_, "$.a2", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 3);
+ res.clear();
+ ASSERT_TRUE(json_->ArrLen(key_, "$.a2[0]", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 3);
+ res.clear();
+ // 3.scaler
Review Comment:
scalar?
##########
tests/cppunit/types/json_test.cc:
##########
@@ -225,3 +225,44 @@ TEST_F(RedisJsonTest, Clear) {
ASSERT_TRUE(json_->Clear(key_, "$.some", &result).ok());
ASSERT_EQ(result, 0);
}
+
+TEST_F(RedisJsonTest, ArrLen) {
+ ASSERT_TRUE(
+ json_->Set(key_, "$",
R"({"a1":[1,2],"a2":[[1,5,7],[8],[9]],"i":1,"s":"string","o":{"a3":[1,1,1]}})").ok());
+ // 1. simple array
+ std::vector<std::optional<uint64_t>> res;
+ ASSERT_TRUE(json_->ArrLen(key_, "$.a1", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 2);
+ res.clear();
+ // 2. nested array
+ ASSERT_TRUE(json_->ArrLen(key_, "$.a2", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 3);
+ res.clear();
+ ASSERT_TRUE(json_->ArrLen(key_, "$.a2[0]", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 3);
+ res.clear();
+ // 3.scaler
+ ASSERT_TRUE(json_->ArrLen(key_, "$.i", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], std::nullopt);
+ res.clear();
+ ASSERT_TRUE(json_->ArrLen(key_, "$.s", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], std::nullopt);
+ res.clear();
+ // 4. object
+ ASSERT_TRUE(json_->ArrLen(key_, "$.o", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], std::nullopt);
+ res.clear();
+ ASSERT_TRUE(json_->ArrLen(key_, "$.o.a3", res).ok());
+ ASSERT_EQ(res.size(), 1);
+ ASSERT_EQ(res[0], 3);
+ res.clear();
+ // 5. path is not found
+ ASSERT_TRUE(json_->ArrLen(key_, "$.o.a4", res).ok());
+ ASSERT_TRUE(res.empty());
+}
Review Comment:
add a test for key not found?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
