git-hulk commented on code in PR #1855:
URL: https://github.com/apache/kvrocks/pull/1855#discussion_r1375394683
##########
src/server/server.cc:
##########
@@ -245,6 +244,9 @@ void Server::Join() {
if (auto s = task_runner_.Join(); !s) {
LOG(WARNING) << s.Msg();
}
+ for (const auto &worker : worker_threads_) {
Review Comment:
It doesn't wait for other threads but can't be the first one, because
worker_threads_ may be modified after starting, so I move it to the last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
