mapleFU commented on code in PR #1855:
URL: https://github.com/apache/kvrocks/pull/1855#discussion_r1375423088


##########
src/server/server.cc:
##########
@@ -117,6 +117,9 @@ Server::~Server() {
   }
 
   lua::DestroyState(lua_);

Review Comment:
   Also. should we adjust the ordering of `lua::DestroyState` and cleanup?( not 
so familiar with lua here, so don't know would we meet the problem)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to