PragmaTwice commented on code in PR #1865:
URL: https://github.com/apache/kvrocks/pull/1865#discussion_r1379790595
##########
src/commands/cmd_json.cc:
##########
@@ -204,11 +205,59 @@ class CommandJsonArrLen : public Commander {
}
};
+class CommanderJsonArrIndex : public Commander {
+ public:
+ Status Execute(Server *svr, Connection *conn, std::string *output) override {
+ redis::Json json(svr->storage, conn->GetNamespace());
+
+ std::vector<ssize_t> result;
+ int start = -1;
Review Comment:
Why here it is `-1` instead of `0`?
##########
src/commands/cmd_json.cc:
##########
@@ -204,11 +205,59 @@ class CommandJsonArrLen : public Commander {
}
};
+class CommanderJsonArrIndex : public Commander {
+ public:
+ Status Execute(Server *svr, Connection *conn, std::string *output) override {
+ redis::Json json(svr->storage, conn->GetNamespace());
+
+ std::vector<ssize_t> result;
+ int start = -1;
Review Comment:
Why here is it `-1` instead of `0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
