wy-ei opened a new pull request, #1886: URL: https://github.com/apache/kvrocks/pull/1886
When parsing listpack and ziplist when loading RDB, they don't correctly handle negetive integer. in This PR i try to fix this. When I fix the problem, I think we can make the code more simpler, and I can't stop myself do those changes: - fix int parse bug in listpack and ziplist - reimplement the next method using a input string stream - remove unused public method of ZipList and ListPack (Length and Next). User can't call this method because it consume the input. Next and Length is used by Entries, we should make them private. In `InputStringStream` I use execption rather than `StatusOr`. If using `StatusOr`, I must wrap every `stream.Read` call in `GET_OR_RET`, this make code hard to read. By using `InputStringStream` you can easily handle offset, you can easily read certain bytes integer and string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
