git-hulk commented on issue #124: URL: https://github.com/apache/kvrocks-controller/issues/124#issuecomment-1821055735
> I'm not very familiar with the Go language, but it seems like this continue is unnecessary. It's indeed a bug that Line 270 should be after [#L271-L273](https://github.com/apache/kvrocks-controller/blob/unstable/storage/persistence/etcd/etcd.go#L271-L273). That said don't emit leader change even if the leader is not changed. > When should we send true to e.leaderChangeCh, and when should we send false? For the initial design intention, we would like to send `true` to the channel if the leader is changed, and `false` if any other events. But from the current implementation, it doesn't care about the value of the channel and always checks if the leader has changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
