git-hulk commented on PR #1901: URL: https://github.com/apache/kvrocks/pull/1901#issuecomment-1822287175
> The mutex pool in lock manager may be reallocated by MultiGet(). Then the old mutex pointers in LockGuard all be invalid...I guess that's why I failed the test. Should I use a std::deque to replace the vector? Guess you should use optional<LockGuard> instead of LockGuard directly in https://github.com/apache/kvrocks/pull/1901/files#diff-642915be939e08850c3ce460033f3cdf0969ab9bfa67b63639e82ab9daf454f6R606-R609. Or it will release the mutex after exiting the if block, and exiting this function will cause to free the mutex again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
