PragmaTwice commented on PR #1901: URL: https://github.com/apache/kvrocks/pull/1901#issuecomment-1826811805
> I am trying to use rocksdb::PinnableSlice to improve Bitmap::SegmentCacheStore. But I failed because of some strange error. When I use `std::unordered_map<uint32_t, rocksdb::PinnableSlice> cache_` and get its iterator, the iterator compare function is failed to instantiate (such as: `it != cache_.end()`), which makes me can not travel `cache_` in `BatchForFlush()`. `rocksdb::Cleanable` has a bug in current rocksdb version(It's copy constructor deleted, but the param of it is not marked const). I think using `PinnableSlice` not required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
