git-hulk commented on PR #1841: URL: https://github.com/apache/kvrocks/pull/1841#issuecomment-1838711380
Some places need to be improved, but I will do it in another PR: - Keep consistent of the integer receiver, should be `std::vector<std::optional<uint64_t>>`. - Add a function to covert `std::vector<std::optional<uint64_t>>` to the Redis output to avoid duplicate code blocks. So I approved this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
