PragmaTwice commented on code in PR #1928:
URL: https://github.com/apache/kvrocks/pull/1928#discussion_r1420357404
##########
src/server/redis_connection.cc:
##########
@@ -393,7 +393,7 @@ void Connection::ExecuteCommands(std::deque<CommandTokens>
*to_process_cmds) {
s = srv_->cluster->CanExecByMySelf(attributes, cmd_tokens, this);
if (!s.IsOK()) {
if (is_multi_exec) multi_error_ = true;
- Reply(redis::Error("ERR " + s.Msg()));
+ Reply(redis::Error(s.Msg()));
Review Comment:
Hmmm. Then no problem to me.
But for the general situation (we cannot control it for nested returned
status right? it will cause huge maintanance effort), I recommend to add some
custom error status and check it here.
I mean, we cannot check every commit every time whether every status need
the ERR code, which is not a neat method to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
