git-hulk commented on code in PR #1935:
URL: https://github.com/apache/kvrocks/pull/1935#discussion_r1428793183
##########
src/types/redis_string.cc:
##########
@@ -217,38 +206,87 @@ rocksdb::Status String::Set(const std::string &user_key,
const std::string &valu
return MSet(pairs, /*ttl=*/0, /*lock=*/true);
}
-rocksdb::Status String::SetEX(const std::string &user_key, const std::string
&value, uint64_t ttl) {
- std::vector<StringPair> pairs{StringPair{user_key, value}};
- return MSet(pairs, /*ttl=*/ttl, /*lock=*/true);
-}
+rocksdb::Status String::Set(const std::string &user_key, const std::string
&value, uint64_t ttl, StringSetType type,
Review Comment:
Is it good to group Set Flags / keepttl/get into one parameter? To avoid too
many input parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
