git-hulk commented on PR #2004: URL: https://github.com/apache/kvrocks/pull/2004#issuecomment-1888292258
@jihuayu Thanks for your review. > 1. I found the test doesn't have Bloom, JSON and SortedInt type. Is that OK? I'm not quite sure about how to add test cases for bloom. Welcome to send a PR after this if anyone knows that. I will also add a test case for JSON and SortedInt. > When I iter the zset subkey, it only returns the subkeys key|version|member=>score, not return subkeys key|version|score|member=>NULL? Yes, it's not necessary to scan the score column family since it has enough information from the subkey column family. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
