git-hulk commented on code in PR #2017:
URL: https://github.com/apache/kvrocks/pull/2017#discussion_r1452135336
##########
src/server/redis_connection.cc:
##########
@@ -130,6 +130,39 @@ void Connection::Reply(const std::string &msg) {
redis::Reply(bufferevent_get_output(bev_), msg);
}
+std::string Connection::Bool(bool b) const {
+ if (protocol_version_ == RESP::v3) {
+ return b ? "#t" CRLF : "#f" CRLF;
+ }
+ return Integer(b ? 1 : 0);
+}
+
+std::string Connection::MultiBulkString(const std::vector<std::string> &values,
+ bool output_nil_for_empty_string)
const {
Review Comment:
Yes, it will set to false if we don't want to convert the empty string to
nil. For example, in SMEMBERS command we don't want to convert the empty member
string to nil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
