git-hulk commented on code in PR #2021:
URL: https://github.com/apache/kvrocks/pull/2021#discussion_r1453273652
##########
src/types/redis_zset.cc:
##########
@@ -930,4 +930,46 @@ rocksdb::Status ZSet::RandMember(const Slice &user_key,
int64_t command_count,
return rocksdb::Status::OK();
}
+rocksdb::Status ZSet::Diff(const std::vector<Slice> &keys, MemberScores
*members) {
+ std::vector<std::string> lock_keys;
Review Comment:
Seem other places also locked keys, so let leave as it is and fix them
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
