PragmaTwice commented on code in PR #2148:
URL: https://github.com/apache/kvrocks/pull/2148#discussion_r1518845264
##########
src/cluster/replication.cc:
##########
@@ -75,7 +75,7 @@ Status FeedSlaveThread::Start() {
conn_ = nullptr; // prevent connection was freed when failed to start the
thread
}
- return s;
+ return std::move(s);
Review Comment:
The type of returned value is not same as the return type. So no.
##########
src/cluster/replication.cc:
##########
@@ -75,7 +75,7 @@ Status FeedSlaveThread::Start() {
conn_ = nullptr; // prevent connection was freed when failed to start the
thread
}
- return s;
+ return std::move(s);
Review Comment:
The type of returned value is not the same as the return type. So no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
