Re: [PR] Update docusaurus.config.js to enable dark mode switch [kvrocks-website]

Wed, 13 Mar 2024 06:25:06 -0700 


git-hulk commented on PR #209:
URL: https://github.com/apache/kvrocks-website/pull/209#issuecomment-1994400946

   > > <img alt="image" width="1896" 
src="https://private-user-images.githubusercontent.com/4987594/312468857-c47be673-fafd-4aa1-af8a-16a853d5ae7c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzMzU4MDYsIm5iZiI6MTcxMDMzNTUwNiwicGF0aCI6Ii80OTg3NTk0LzMxMjQ2ODg1Ny1jNDdiZTY3My1mYWZkLTRhYTEtYWY4YS0xNmE4NTNkNWFlN2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMTMxMTQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODExODVlM2JiNzIzOThlM2I4OTA3YTUyMTJmNTMxMTI0ZWNiNjNlOWJiZTIzMmIyZGVhYzZiZTc1YjdiYzgwOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0HOnUdRiT5OhGsPrv-t-2IZKWtBG1NUMa1_D5f1juRc";>
 @tisonkun Yes, but it looks good for now(from my personal perspective).
   > 
   > Really good? I cannot understand your point. The home page looks really 
bad in dark mode:
   > 
   > * The banner is still in light mode.
   > * Buttons are still in light mode.
   > * Namespace icon has a white rectangular frame.
   
   😭 Maybe I have a bad sense of web UI, so I think those inconsistent colors 
between them are good for me. So I just mentioned that's my perspective.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to