torwig commented on code in PR #2169:
URL: https://github.com/apache/kvrocks/pull/2169#discussion_r1524912521
##########
src/types/redis_stream.cc:
##########
@@ -314,6 +314,48 @@ StreamSubkeyType Stream::identifySubkeyType(const
rocksdb::Slice &key) const {
return StreamSubkeyType::StreamConsumerMetadata;
}
+rocksdb::Status Stream::DeletePelEntries(const Slice &stream_name, const
std::string &group_name,
+ const std::vector<StreamEntryID>
&entry_set, uint64_t &acknowledged) {
Review Comment:
And here we can change `entry_set` to `entry_ids`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]