mapleFU commented on code in PR #2171:
URL: https://github.com/apache/kvrocks/pull/2171#discussion_r1527030452
##########
src/config/config.cc:
##########
@@ -190,6 +190,7 @@ Config::Config() {
{"rocksdb.compression", false,
new EnumField<rocksdb::CompressionType>(&rocks_db.compression,
compression_types,
rocksdb::CompressionType::kNoCompression)},
+ {"rocksdb.compression_level", true, new
IntField(&rocks_db.compression_level, 32767, INT_MIN, INT_MAX)},
Review Comment:
Rocksdb don't have this interface is fair enough, however, I don't think
changing the level need re-encoding. And decompress block also doesn't need the
level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
