jihuayu commented on code in PR #2170:
URL: https://github.com/apache/kvrocks/pull/2170#discussion_r1527342494
##########
src/common/status.h:
##########
@@ -163,7 +163,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) <
sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new
std::string(*std::move(v))) {} // NOLINT
template <typename U, typename
std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
The format is introduced by clang-format-16 and Kvrocks is now using
clang-format-14, so you can change the clang-format to 14 to make the CI happy.
Can we disable this behavior in `.clang-format`? Or disable the formatting
for this line of code? This situation occurs quite frequently. @PragmaTwice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
