mapleFU commented on issue #1212:
URL: https://github.com/apache/kvrocks/issues/1212#issuecomment-2002199455

   1. Redis' impl uses code below: 
https://github.com/redis/redis/blob/unstable/src/bitops.c#L984-L997
   2. bitpos util syntax would be clear: returning the "kth" bit in the input. 
   
   I think we'd better keep RawBitpos clean and clear, and handling the dirty 
logic in `BitmapString::BitPos`.
   
   ( besides, I think `stop_given` and `bit` is really tricky in redis, sigh)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to