mapleFU commented on code in PR #2178:
URL: https://github.com/apache/kvrocks/pull/2178#discussion_r1528507686
##########
src/types/json.h:
##########
@@ -151,11 +151,34 @@ struct JsonValue {
Status Set(std::string_view path, JsonValue &&new_value) {
try {
- jsoncons::jsonpath::json_replace(value, path, [&new_value](const
std::string & /*path*/, jsoncons::json &origin) {
- origin = new_value.value;
- });
+ bool is_set = false;
+ jsoncons::jsonpath::json_replace(value, path,
+ [&new_value, &is_set](const std::string
& /*path*/, jsoncons::json &origin) {
+ origin = new_value.value;
+ is_set = true;
+ });
+
+ if (!is_set) {
+ // NOTE: this is a workaround since jsonpath doesn't support replace
for nonexistent paths in jsoncons
+ // and in this workaround we can only accept normalized path
+ // refer to https://github.com/danielaparker/jsoncons/issues/496
+ jsoncons::jsonpath::json_location location =
jsoncons::jsonpath::json_location::parse(path);
Review Comment:
oh got it, nice patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
