PragmaTwice opened a new pull request, #2220: URL: https://github.com/apache/kvrocks/pull/2220
### Why to disable: Currently, in kvrocks codebase there are three place for the logic of executing command: - Connection::ExecuteCommands - redis command execution in lua scripting - the ANALYSE command It's very hard to maintain in these three places and even implement the correct logic. And there are so many wrong/missing point in the command execution part of ANALYZE: - command attribute flags are totally be ignored (it can cause issue in some cases like replica executing write commnds) - it can cause issue in MULTI-EXEC and also scripting since the flags are not dynamically added properly - it cannot be traced by WATCH/UNWATCH - it cannot handle blocking commands - cluster related staff ### How to design: Actually we should reconsider how to design such a command and its workflow, to trade off between maintainibility, completeness and user exprience. e.g. - How to maintain the command executing logic properly, to avoid so many missing? - How to respond to user properly? Could we use attribute in RESP3? - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
