mapleFU commented on code in PR #2234:
URL: https://github.com/apache/kvrocks/pull/2234#discussion_r1559319594
##########
src/search/ir.h:
##########
@@ -106,16 +116,23 @@ struct TagContainExpr : BoolAtomExpr {
NodeIterator ChildBegin() override { return {field.get(), tag.get()}; };
NodeIterator ChildEnd() override { return {}; };
+
+ std::unique_ptr<Node> Clone() const override {
+ return
std::make_unique<TagContainExpr>(Node::MustAs<FieldRef>(field->Clone()),
+
Node::MustAs<StringLiteral>(tag->Clone()));
+ }
};
-struct NumericLiteral : Node {
+struct NumericLiteral : Literal {
Review Comment:
Btw, do we have a Literal class for all literals(which is not a node), which
could be used in filters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
