tutububug commented on code in PR #2142:
URL: https://github.com/apache/kvrocks/pull/2142#discussion_r1565227358


##########
tests/cppunit/types/hyperloglog_test.cc:
##########


Review Comment:
   Adding 'srand' here to make HLL elements completely random should be 
necessary, but it may cause larger error and the error range cannot be 
evaluated (now it is 5.1%), this will affect the stability of ci's unit test 
execution. So it can only be removed first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to