PragmaTwice commented on code in PR #2262:
URL: https://github.com/apache/kvrocks/pull/2262#discussion_r1580477854
##########
src/storage/redis_db.cc:
##########
@@ -937,7 +937,7 @@ rocksdb::Status Database::Sort(const RedisType &type, const
std::string &key, co
for (const std::string &pattern : args.getpatterns) {
std::string val = lookupKeyByPattern(pattern, elem.obj);
if (val.empty()) {
- elems->emplace_back(redis::NilString(version));
+ elems->emplace_back("");
Review Comment:
Hmmm seems we need to distinguish between nil and empty string here?
If so we need to use something like `vector<optional<string>>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
