Beihao-Zhou commented on code in PR #2202:
URL: https://github.com/apache/kvrocks/pull/2202#discussion_r1581170841
##########
src/commands/cmd_stream.cc:
##########
@@ -242,6 +242,100 @@ class CommandXDel : public Commander {
std::vector<redis::StreamEntryID> ids_;
};
+class CommandXClaim : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ if (args.size() < 6) {
+ return {Status::RedisParseErr, errWrongNumOfArguments};
+ }
+
+ CommandParser parser(args, 1);
+ stream_name_ = GET_OR_RET(parser.TakeStr());
+ group_name_ = GET_OR_RET(parser.TakeStr());
+ consumer_name_ = GET_OR_RET(parser.TakeStr());
+ min_idle_time_ = GET_OR_RET(parser.TakeInt<uint64_t>());
Review Comment:
I see I see, just wondering if that's the case, for `idle`, `time` and
`retrycount`, are they all going to be int64_t, followed by parse result
checking such that only non-negative values are allowed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
