PragmaTwice commented on issue #2279: URL: https://github.com/apache/kvrocks/issues/2279#issuecomment-2083147419
> For setting the `write_buff_size` for each column family. There are a simple way that i can think of is to extend `config set rocksdb.write_buffer_size num` command. > > For example, the command of `config set rocksdb.write_buffer_size [cf_name] num` is used to set the buff_size of the specify cf. > > More example: > > ```shell > config set rocksdb.write_buffer_size ALL num > # equivalent to `config set rocksdb.write_buffer_size num` > # settings the buff_size for all of column families > > config set rocksdb.write_buffer_size MAJOR num > # for major colunm families include metadata and default > > config set rocksdb.write_buffer_size MINOR num > # for minor colunm families except for metadata and default > > config set rocksdb.write_buffer_size [metadate | default | zset | pubsub | ... ] num > # for specify column family > ``` That's a good idea. However, here are two things that need to be considered: - how to be compatible with old config files - previously I try to make all config keys unique, since it will make the config part more intuitive and easy to process in the code level, especially for GET and REWRITE (I spent lots of time to rewrite code of the config part). But this design will break it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
